SpaceViewBlueprint is now python serializable #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🐍 Python API
jleibs
approved these changes
Mar 5, 2024
|
|
||
|
|
||
| class VisibleExt: | ||
| """Extension for [Visible][rerun.components.Visible].""" |
There was a problem hiding this comment.
This will need to get fixed in merge.
| contents_arrays = [[uuid_bytes0, uuid_bytes1], [IncludedQuery(uuid_bytes0), IncludedQuery(uuid_bytes1)], None] | ||
| visible_arrays = [False, Visible(False), None] | ||
|
|
||
| all_arrays = itertools.zip_longest( |
There was a problem hiding this comment.
FYI, zip_longest appears to lead to mypy lint errors. In my PR I had to add:
container_kind = cast(ContainerKindLike, container_kind)
display_name = cast(Optional[Utf8Like], display_name)
contents = cast(Optional[EntityPathArrayLike], contents)
col_shares = cast(Optional[ColumnShareArrayLike], col_shares)
row_shares = cast(Optional[RowShareArrayLike], row_shares)
active_tab = cast(Optional[EntityPathLike], active_tab)
visible = cast(Optional[VisibleLike], visible)
grid_columns = cast(Optional[GridColumnsLike], grid_columns)
to fix it 😭
jleibs
force-pushed
the
andreas/serializable-spaceviewblueprint
branch
2 times, most recently
from
af1733e to
4095985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Plus the usual amount of plumbing, following overall similar patterns than the previous PRs in this area
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io